[PATCH 08/27] bfd/ELF: mark internal MIPS functions hidden
Maciej W. Rozycki
macro@orcam.me.uk
Sat Nov 8 14:50:12 GMT 2025
On Fri, 7 Nov 2025, Jan Beulich wrote:
> >> This reduces the dynamic symbol table some and allows the compiler to be
> >> more aggressive about inlining (as it sees fit, of course).
> >
> > Fine with me, thanks (for whoever cares to build BFD as a DSO).
>
> Actually, noticing only now: sim/mips/acinclude.m4 uses _bfd_elf_mips_mach().
> It's unclear to me whether making the function hidden would break anything
> there.
It does, at least with the `mips64-linux-gnu' target:
/usr/bin/ld: mips/libsim.a(multi-run.o): in function `sim_engine_run':
multi-run.c:(.text+0x70): undefined reference to `_bfd_elf_mips_mach'
collect2: error: ld returned 1 exit status
in a `--enable-shared --disable-static' build. Please discard this part
of the change then.
Maciej
More information about the Binutils
mailing list