[PATCH v3] PowerPC: Support for SHA2 and SHA3 Compute Instructions (RFC02654)

Peter Bergner bergner@tenstorrent.com
Fri Nov 7 20:45:00 GMT 2025


I'm letting Surya review the patch, but...

On 11/7/25 5:50 AM, Abhay Kandpal wrote:

> +  /* The Third field in MMA instruction for Hash.  */
> +#define HASHT IMM20 + 1
>    /* The L field in a D or X form instruction.  */
>  #define L IMM20 + 1
>    { 0x1, 21, NULL, NULL, 0 },

Don't have both HASHT and L both be defined to 'IMM20 + 1'.
It's probably best just to move the definition of HASHT below
that of L and define it as:

#define HASHT L

...or keeping the same order above, changing L to be:

#define L HASHT.


Peter




More information about the Binutils mailing list