[PATCH] x86: support SALC

Jan Beulich jbeulich@suse.com
Thu Nov 6 07:30:06 GMT 2025


On 01.11.2025 23:59, Maciej W. Rozycki wrote:
> On Fri, 31 Oct 2025, Jan Beulich wrote:
> 
>> Now that the SDM (finally) at least mentions it (without giving it a
>> proper instruction page, though), let's (again: finally) also support it
>> in assembler and disassembler.
>>
>> --- a/gas/testsuite/gas/i386/opcode.d
>> +++ b/gas/testsuite/gas/i386/opcode.d
>> @@ -587,7 +587,8 @@ Disassembly of section .text:
>>   9f5:	85 c3 [ 	]*test   %eax,%ebx
>>   9f7:	85 d8 [ 	]*test   %ebx,%eax
>>   9f9:	85 18 [ 	]*test   %ebx,\(%eax\)
>> - 9fb:	f1 [ 	]*int1
>> +[ 	]*[a-f0-9]+:	f1[ 	]*int1
>> +[ 	]*[a-f0-9]+:	d6[ 	]*salc
>>  [ 	]*[a-f0-9]+:	0f 4a 90 90 90 90 90 	cmovp  -0x6f6f6f70\(%eax\),%edx
>>  [ 	]*[a-f0-9]+:	0f 4b 90 90 90 90 90 	cmovnp -0x6f6f6f70\(%eax\),%edx
>>  [ 	]*[a-f0-9]+:	66 0f 4a 90 90 90 90 90 	cmovp  -0x6f6f6f70\(%eax\),%dx
> 
>  Why the unrelated change to `int1' (and likewise throughout)?

Minimal style improvements on earlier additions, in immediately adjacent code.
Really the whole file (and much of the testsuite) could do with such, but I
think it's better to do so incrementally. (And just to mention - I really
consider this an overly nit-picky question.)

Jan


More information about the Binutils mailing list