[PATCH] s390: Fix format specifier for VR in disassembler

Jens Remus jremus@linux.ibm.com
Wed May 7 15:21:03 GMT 2025


On 05.05.2025 17:20, Andreas Krebbel wrote:
> Ok, thanks!

Thank you for the review! Committed to mainline with Andreas' approval.

> On 5/5/25 12:34 PM, Jens Remus wrote:
>> Vector register (VR) numbers are unsigned.  Use format specifier %u
>> instead of %i.
>>
>> Reported-by: Florian Krohm <flo2030@eich-krohm.de>
>> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
>> ---
>>   opcodes/s390-dis.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/opcodes/s390-dis.c b/opcodes/s390-dis.c
>> index 98383658c47a..0d32d050d654 100644
>> --- a/opcodes/s390-dis.c
>> +++ b/opcodes/s390-dis.c
>> @@ -312,7 +312,7 @@ s390_print_insn_with_opcode (bfd_vma memaddr,
>>         info->fprintf_styled_func (info->stream, dis_style_text,
>>                        "%c", separator);
>>         info->fprintf_styled_func (info->stream, dis_style_register,
>> -                     "%%v%i", val.u);
>> +                     "%%v%u", val.u);
>>       }
>>         else if (flags & S390_OPERAND_AR)
>>       {

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/



More information about the Binutils mailing list