[PATCH] gprof: Always compile tests with -g

[H.J. Lu]

On Sat, Mar 29, 2025 at 6:35 AM Sam James <sam@gentoo.org> wrote:
>
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
> > Always compile gprof testsuite with -g for line number info checked by
> > tst-gmon-gprof-l.sh.
> >
> >       PR gprof/32779
> >       * testsuite/Makefile.am (GPROF_FLAGS): Add -g.
> >       (COMPILE): Set to "$(CC) $(AM_CFLAGS) $(GPROF_FLAGS)".
> >       (LINK) Set to "$(CC) $(AM_CFLAGS) $(GPROF_FLAGS) $(AM_LDFLAGS)
> >       $(LDFLAGS) -o $@".
> >       * testsuite/Makefile.in: Regenerated.
>
> LGTM.
>
> >
> > Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> > ---
> >  gprof/testsuite/Makefile.am | 10 +++++-----
> >  gprof/testsuite/Makefile.in | 12 +++++-------
> >  2 files changed, 10 insertions(+), 12 deletions(-)
> >
> > diff --git a/gprof/testsuite/Makefile.am b/gprof/testsuite/Makefile.am
> > index c4d6c41fcf4..0c80b12e6e4 100644
> > --- a/gprof/testsuite/Makefile.am
> > +++ b/gprof/testsuite/Makefile.am
> > @@ -6,12 +6,12 @@ GPROF = ../gprof$(EXEEXT)
> >
> >  # NB: -O2 -fno-omit-frame-pointer is needed for expected call graph.  See
> >  # https://sourceware.org/bugzilla/show_bug.cgi?id=32768
> > -GPROF_FLAGS = -O2 -fno-omit-frame-pointer -pg
> > +# -g is needed for line number info checked by tst-gmon-gprof-l.sh.  See
> > +# https://sourceware.org/bugzilla/show_bug.cgi?id=32779
> > +GPROF_FLAGS = -O2 -fno-omit-frame-pointer -pg -g
> >
> > -COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
> > -     $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(GPROF_FLAGS)
> > -LINK = $(CC) $(AM_CFLAGS) $(CFLAGS) $(OPT_NO_PLUGINS) $(GPROF_FLAGS) \
> > -     $(AM_LDFLAGS) $(LDFLAGS) -o $@
> > +COMPILE = $(CC) $(AM_CFLAGS) $(GPROF_FLAGS)
> > +LINK = $(CC) $(AM_CFLAGS) $(GPROF_FLAGS) $(AM_LDFLAGS) $(LDFLAGS) -o $@
> >
> >  # We will add to these later, for each individual test.  Note
> >  # that we add each test under check_SCRIPTS;
> > diff --git a/gprof/testsuite/Makefile.in b/gprof/testsuite/Makefile.in
> > index 008f6be879e..2ac5f241012 100644
> > --- a/gprof/testsuite/Makefile.in
> > +++ b/gprof/testsuite/Makefile.in
> > @@ -496,13 +496,11 @@ GPROF = ../gprof$(EXEEXT)
> >
> >  # NB: -O2 -fno-omit-frame-pointer is needed for expected call graph.  See
> >  # https://sourceware.org/bugzilla/show_bug.cgi?id=32768
> > -GPROF_FLAGS = -O2 -fno-omit-frame-pointer -pg
> > -COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
> > -     $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS) $(GPROF_FLAGS)
> > -
> > -LINK = $(CC) $(AM_CFLAGS) $(CFLAGS) $(OPT_NO_PLUGINS) $(GPROF_FLAGS) \
> > -     $(AM_LDFLAGS) $(LDFLAGS) -o $@
> > -
> > +# -g is needed for line number info checked by tst-gmon-gprof-l.sh.  See
> > +# https://sourceware.org/bugzilla/show_bug.cgi?id=32779
> > +GPROF_FLAGS = -O2 -fno-omit-frame-pointer -pg -g
> > +COMPILE = $(CC) $(AM_CFLAGS) $(GPROF_FLAGS)
> > +LINK = $(CC) $(AM_CFLAGS) $(GPROF_FLAGS) $(AM_LDFLAGS) $(LDFLAGS) -o $@
> >
> >  # We will add to these later, for each individual test.  Note
> >  # that we add each test under check_SCRIPTS;

I am checking it in.

-- 
H.J.