[PATCH v1 14/14] ld tests for AArch64-specific merge coverage for AEABI Build Attributes

Richard Earnshaw (lists) Richard.Earnshaw@arm.com
Mon Mar 24 17:44:01 GMT 2025


On 24/03/2025 09:18, Jan Beulich wrote:
> On 21.03.2025 18:14, Matthieu Longo wrote:
>> --- /dev/null
>> +++ b/ld/testsuite/ld-aarch64/build-attributes/ba-aarch64-1-bti-1.s
>> @@ -0,0 +1,9 @@
>> +.aeabi_subsection aeabi_feature_and_bits, optional, uleb128
>> +.aeabi_attribute  Tag_Feature_BTI, 1
>> +
>> +	.text
>> +	.globl _start
>> +	.type _start,@function
>> +_start:
>> +	bl foo
>> +	bl bar
>> \ No newline at end of file
> 
> As said already in reply to v0, can you please make sure that _all_ new files
> you introduce properly end in a newline? This really should go without saying,
> here and elsewhere.
> 
> Jan

We should probably have some git hooks that would reject pushes of code like this (provided there's a way of adding exceptions for some specific tests).  Similarly for code with CR/LF line endings.  Most of the time that is just wrong.

R.


More information about the Binutils mailing list