[PATCH] PowerPC: Support for Prefixed Add Immediate Shifted Instruction (RFC02686)

[Surya Kumari Jangala]

Hi Jan,

On 06/03/25 6:55 pm, Jan Beulich wrote:
>> @@ -4031,9 +4087,15 @@ const unsigned int num_powerpc_operands = ARRAY_SIZE (powerpc_operands);
>>  /* An 8-byte D form prefix instruction.  */
>>  #define P_D_MASK (((-1ULL << 50) & ~PCREL_MASK) | OP_MASK)
>>  
>> +/* An 8-byte D form prefix instruction with 32bit SI field.  */
>> +#define P_D_SI32_MASK (((-1ULL << 48) & ~PCREL_MASK) | OP_MASK)
>> +
>>  /* The same as P_D_MASK, but with the RA and PCREL fields specified.  */
>>  #define P_DRAPCREL_MASK (P_D_MASK | PCREL_MASK | RA_MASK)
>>  
>> +/* The same as P_D_MASK, but with the RA and PCREL fields specified.  */
>> +#define P_DRAPCREL_SI32_MASK (P_D_SI32_MASK | PCREL_MASK | RA_MASK)
> 
> Does this define's comment perhaps mean to reference P_D_SI32_MASK?

Yes, the comment should refer to P_D_SI32_MASK. Thanks for catching it!

> 
> Jan