[PATCH v0 03/15] gas: parse object attributes v2

[Jan Beulich]

On 10.03.2025 18:51, Matthieu Longo wrote:
> From: Richard Ball <richard.ball@arm.com>
> 
> Co-Authored-By: Matthieu Longo <matthieu.longo@arm.com>
> ---
>  gas/config/obj-elf.c    | 411 ++++++++++++++++++++++++++++++++++++++++
>  gas/config/obj-elf.h    |  27 +++
>  gas/config/tc-aarch64.c | 102 ++++++++++
>  gas/config/tc-aarch64.h |   5 +
>  4 files changed, 545 insertions(+)

Same as patch 2 - this needs to come with a description. That description would
include explanation of the split between generic ELF and Arm64 specific code.
It's not obvious to me whether any other architecture really would want to
re-use the machinery. Plus ...

> --- a/gas/config/obj-elf.c
> +++ b/gas/config/obj-elf.c
> @@ -41,6 +41,10 @@
>  #include "elf/alpha.h"
>  #endif
>  
> +#ifdef TC_AARCH64
> +#include "elf/aarch64.h"
> +#endif
> +
>  #ifdef TC_MIPS
>  #include "elf/mips.h"
>  #endif

... despite pre-existing examples like the MIPS one here I don't think we
should lightly accept further arch-specific code in supposedly arch-agnostic
files.

> @@ -2127,6 +2131,413 @@ obj_elf_seen_attribute (int vendor, unsigned int tag)
>    return false;
>  }
>  
> +static bool
> +extract_string_literal (attribute_arg_value* arg_out)

Style nit (here and elsewhere): * and blank want to change places.

Jan