[PATCH] gprofng: Fix cross-compilation binary name.

Vladimir Mezentsev vladimir.mezentsev@oracle.com
Mon Mar 10 17:58:02 GMT 2025


Hello Zheng,

please apply your fixes.

Thank you,
-Vladimir


On 2/10/25 01:18, Zheng Junjie wrote:
> hello, when i use binutils 2.44 to cross-compilation, I found that
> install-exec-local in gprofng/src/Makefile.am had the wrong binary name
> when cross-compiled, so the symlink created was invalid link.
>
> The following patch should be able to fix it.
>
>
> 0001-gprofng-Fix-cross-compilation-binary-name.patch
>
>  From b499f0c797779a6d7ff01445aebd2fcc47aac357 Mon Sep 17 00:00:00 2001
> From: Zheng Junjie<zhengjunjie@iscas.ac.cn>
> Date: Mon, 10 Feb 2025 17:04:55 +0800
> Subject: [PATCH] gprofng: Fix cross-compilation binary name.
>
> commit d25ba4596e85da6d8af78c88b5917e14763afbe1 create symbolic link
> no care cross-compilation prefix.
>
> gprofng/ChangeLog
> 2025-02-10  Zheng Junjie<zhengjunjie@iscas.ac.cn>
> 	* src/Makefile.am: create symbolic link respect cross-compilation.
> 	* src/Makefile.in: Rebuild.
> ---
>   gprofng/src/Makefile.am | 12 +++++-------
>   gprofng/src/Makefile.in | 12 +++++-------
>   2 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/gprofng/src/Makefile.am b/gprofng/src/Makefile.am
> index a132a9ddb05..0465cdb06e3 100644
> --- a/gprofng/src/Makefile.am
> +++ b/gprofng/src/Makefile.am
> @@ -179,10 +179,8 @@ $(srcdir)/DbeSession.cc: QLParser.tab.hh
>   .PHONY: install-exec-local
>   install-exec-local:
>   	$(mkinstalldirs) $(DESTDIR)$(bindir)
> -	rm -f $(DESTDIR)$(bindir)/gp-{archive,collect-app,display-html,display-src,display-text}
> -	ln -s gprofng-archive $(DESTDIR)$(bindir)/gp-archive
> -	ln -s gprofng-collect-app $(DESTDIR)$(bindir)/gp-collect-app
> -	ln -s gprofng-display-html $(DESTDIR)$(bindir)/gp-display-html
> -	ln -s gprofng-display-src $(DESTDIR)$(bindir)/gp-display-src
> -	ln -s gprofng-display-text $(DESTDIR)$(bindir)/gp-display-text
> -
> +	for i in gp-{archive,collect-app,display-html,display-src,display-text}; do \
> +		oldname=`echo $$i | sed '$(transform)'`; \
> +		rm -f $(DESTDIR)$(bindir)/$$oldname ; \
> +		ln -s `echo $$oldname | sed 's&gp-&gprofng-&'` $(DESTDIR)$(bindir)/$$oldname; \
> +	done
> diff --git a/gprofng/src/Makefile.in b/gprofng/src/Makefile.in
> index d0dec12e244..d6f1f9438b6 100644
> --- a/gprofng/src/Makefile.in
> +++ b/gprofng/src/Makefile.in
> @@ -1119,13 +1119,11 @@ $(srcdir)/DbeSession.cc: QLParser.tab.hh
>   .PHONY: install-exec-local
>   install-exec-local:
>   	$(mkinstalldirs) $(DESTDIR)$(bindir)
> -	rm -f $(DESTDIR)$(bindir)/gp-{archive,collect-app,display-html,display-src,display-text}
> -	ln -s gprofng-archive $(DESTDIR)$(bindir)/gp-archive
> -	ln -s gprofng-collect-app $(DESTDIR)$(bindir)/gp-collect-app
> -	ln -s gprofng-display-html $(DESTDIR)$(bindir)/gp-display-html
> -	ln -s gprofng-display-src $(DESTDIR)$(bindir)/gp-display-src
> -	ln -s gprofng-display-text $(DESTDIR)$(bindir)/gp-display-text
> -
> +	for i in gp-{archive,collect-app,display-html,display-src,display-text}; do \
> +		oldname=`echo $$i | sed '$(transform)'`; \
> +		rm -f $(DESTDIR)$(bindir)/$$oldname ; \
> +		ln -s `echo $$oldname | sed 's&gp-&gprofng-&'` $(DESTDIR)$(bindir)/$$oldname; \
> +	done
>   # Tell versions [3.59,3.63) of GNU make to not export all variables.
>   # Otherwise a system limit (for SysV at least) may be exceeded.
>   .NOEXPORT:
> -- 2.47.1



More information about the Binutils mailing list