[PATCH 6/6] gprof: only process line numbers for intersection of vmas and histograms

H.J. Lu hjl.tools@gmail.com
Thu Mar 6 07:30:14 GMT 2025


On Thu, Mar 6, 2025 at 11:55 AM Sam James <sam@gentoo.org> wrote:
>
> Richard Allen <rsaxvc@gmail.com> writes:
>
> Hi!
>
> > Some programs like RTOS firmware may have a large number of symbols.
> >
> > By loading the histograms before loading symbols, we can look up
> > only the line numbers that were captured in the histogram file,
> > which reduces processing time for such a firmware from ~2 minutes
> > to ~2 seconds.
> >
> > Signed-off-by: Richard Allen <rsaxvc@gmail.com>
>
>
> This seems to regress glibc's gmon tests
> (https://sourceware.org/PR32764):
>
> tst-gmon-gprof.test-result:FAIL: gmon/tst-gmon-gprof
> tst-gmon-pie-gprof.test-result:FAIL: gmon/tst-gmon-pie-gprof
> tst-gmon-static-gprof.test-result:FAIL: gmon/tst-gmon-static-gprof
> tst-gmon-static-pie-gprof.test-result:FAIL: gmon/tst-gmon-static-pie-gprof
>
> Could you take a look? Thanks.

Since this change is simply wrong, I am going to revert it.
Ricard, if you can provide a patch, I can test it for you.

Thanks.

-- 
H.J.


More information about the Binutils mailing list