[PATCH v3 1/4] bfd,ld,dlltool: Emit delay-load import data into its own section

[Jeremy Drake]

On Wed, 11 Jun 2025, Jan Beulich wrote:

> On 10.06.2025 23:14, Jeremy Drake wrote:
> > Please let me know if you would prefer just pulling the necessary parts
> > into patch 1 for the tests to pass, or to squash all of patch 2 into patch
> > 1?
>
> Moving just the necessary parts would be preferred, but I wouldn't insist on
> that approach (so long as the descriptions would then also properly reflect
> the folded contents).
>
> > In the meantime, I suppose I need to figure out how to run the tests on
> > Windows ;)
>
> Assuming you're using Cygwin or MinGW there, running "make check" ought to
> be all you need. Provided of course you have the necessary packages installed.

I was able to run the tests on Cygwin targeting x86_64-w64-mingw32, but I
had a couple of failures.  Luckily they weren't related to anything this
patch series was doing, so I was able to reproduce the failures you saw
and confirm they did not occur when moving the scripttempl change to patch
1.

I did have a look at tests for 'normal' imports, but I didn't see any
obvious way they could be adapted to tell anything useful about 'delay'
imports.  The dlltool tests seem to use `nm` to confirm the expected
symbols are present (which doesn't tell you anything about the
construction of the import library), and the ld-pe tests seem to use
`objdump -p` which dumps the import directory but doesn't dump the delay
import directory (in fact, the delay import directory wasn't even being
filled in until patch 4 of this series).