[PATCH v3 02/26] Remove annoying spaces from bfd/elfxx-aarch64.c

Matthieu Longo matthieu.longo@arm.com
Wed Jun 11 12:45:01 GMT 2025


On 2025-06-10 18:18, Richard Earnshaw wrote:
> On 09/05/2025 16:12, Matthieu Longo wrote:
>> ---
>>   bfd/elfxx-aarch64.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c
>> index 68e004ef7cb..551f74e3373 100644
>> --- a/bfd/elfxx-aarch64.c
>> +++ b/bfd/elfxx-aarch64.c
>> @@ -708,7 +708,7 @@ static inline bool
>>   bfd_is_non_dynamic_elf_object (bfd *abfd, const struct 
>> elf_backend_data *out_be)
>>   {
>>     const struct elf_backend_data *in_be = get_elf_backend_data (abfd);
>> -
>> +
>>     return bfd_get_flavour (abfd) == bfd_target_elf_flavour
>>       && bfd_count_sections (abfd) != 0
>>       && (abfd->flags & (DYNAMIC | BFD_PLUGIN | BFD_LINKER_CREATED)) == 0
> 
> I'd generally regard changes like this as obvious, but I'd only make 
> them if I'm changing the code local to the cleanup and then just slip 
> them in as part of that.  It's not generally something I'd do as a 
> stand-alone commit.
> 
> R.

I understand that this patch is a bit "ridiculous" in appearance.

To give you the context here, I reworked the commits a lot during the 
development and the previous code reviews. If I was keeping this change 
in one specific commit, then it would annoy me again when I move a 
future commit on the same file before this commit.
To be clear, this is not the move of the commit that creates the issue 
but when I edit the file with my editor that removes automatically the 
spaces at the end of the lines when I save.
I don't want to disable this editor feature because it is very useful to 
not insert new useless spaces everywhere when I write/change code.

Matthieu


More information about the Binutils mailing list