[PATCH v3 04/26] bfd/elf-attrs.c: use ASCII character '(0x27) for single quote

[Richard Earnshaw (lists)]

On 09/05/2025 16:12, Matthieu Longo wrote:
> ---
>  bfd/elf-attrs.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/bfd/elf-attrs.c b/bfd/elf-attrs.c
> index bc653d780de..b4a57f4803c 100644
> --- a/bfd/elf-attrs.c
> +++ b/bfd/elf-attrs.c
> @@ -104,7 +104,7 @@ vendor_obj_attrs_v1_size (bfd *abfd, int vendor)
>         list = list->next)
>      size += obj_attr_v1_size (list->tag, &list->attr);
>  
> -  /* <size> <vendor_name> NUL 0x1 <size> */
> +  /* <size> <vendor_name> NUL 0x1 <size>  */
>    return (size
>  	  ? size + 10 + strlen (vendor_name)
>  	  : 0);
> @@ -117,7 +117,7 @@ bfd_elf_obj_attrs_v1_size (bfd *abfd)
>    size = vendor_obj_attrs_v1_size (abfd, OBJ_ATTR_PROC);
>    size += vendor_obj_attrs_v1_size (abfd, OBJ_ATTR_GNU);
>    if (size > 0)
> -    size += sizeof(uint8_t); /* <format-version: ‘A’>  */
> +    size += sizeof(uint8_t); /* <format-version: 'A'>  */
>    return size;
>  }
>  
> @@ -212,7 +212,7 @@ write_obj_attr_section_v1 (bfd *abfd, bfd_byte *buffer, bfd_vma size)
>  {
>    bfd_byte *p = buffer;
>  
> -  /* <format-version: ‘A’>  */
> +  /* <format-version: 'A'>  */
>    *(p++) = 'A';
>  
>    for (int vendor = OBJ_ATTR_FIRST; vendor <= OBJ_ATTR_LAST; ++vendor)

I can't approve this patch (or reject it), but I do wonder why you think it's needed.  There's nothing in the commit message to give justification for it's need.

R.