[PATCH, V3 5/6] libsframe: stop search for SFrame FRE if its start IP is greater than PC

[Jan Beulich]

On 06.06.2025 18:45, Indu Bhagat wrote:
> On 6/6/25 3:15 AM, Jens Remus wrote:
>>>>> The removal of these two local vars looks unrelated. I won't insist on this
>>>>> being moved to a separate patch, but the change then wants mentioning in the
>>>>> description (to at least make clear it's deliberate, not a mistake).
>>>> The removal is related, as below (re-cited) change removes the only user
>>>> of mask_p, making it necessary to remove it.  This in turn removes the
>>>> only user of fde_type, making it necessary to remove that as well.
>>> Oh, I see, I overlooked that. I had looked for only fde_type uses, and
>>> there were none that were removed from the code below.
>>>
>>>> Given Indu has already committed the patch to mainline (presumably as
>>>> libsframe maintainer) I can no longer amend the description.  Sorry!
>>> Yeah, I only later noticed these went in already. Given my oversight this
>>> is fine as is anyway.
>> I really value your feedback, as it will help me improve my patches in
>> the future.
> 
> Same here, I appreciate your reviews and feedback each time.
> 
> And apologies for the confusion; I will send a Committed/Pushed note for such cases from now on to reflect the change of status.

Sorry, I don't think there's a need for this. It was me who screwed up,
after all. Partly caused by me having been away from work for more than
half of May.

Jan