[PATCH,V2 0/9] Fix relocatable SFrame links

[Jens Remus]

Hello Indu!

On 04.06.2025 09:08, Indu Bhagat via Binutils wrote:
> This patch series fixes two SFrame issues related to relocatable links.
>   PR/32666  Incorrect .rela.sframe when using ld -r
>   PR libsframe/32589 - function start address is zero in SFrame section dump
> 
> Compared to V1, this series has reduced number of patches:
>   - V1 patch "sframe: doc: add date to the pdf output" is already
>     committed.
>   - Merged three patches in V1 into a single patch in V2.
>     include: libsframe: add APIs for offsetof FDE func start addr field
>     doc: sframe: add documentation for SFRAME_F_FDE_FUNC_START_ADDR_PCREL
>     doc: sframe: update documentation for sfde_func_start_address
>   - V2 also addresses the review feedback so far.
> 
> This series is based on the previously suggested "Scheme#B" approach, an RFC of
> which was previously deemed the right way to fix these issues.  In this
> approach, we add a new flag in the SFrame version 2 specification,
> SFRAME_F_FDE_FUNC_START_ADDR_PCREL. With the fixes, gas and ld always emit this
> flag by default.
> 
> [RFC,SCHEME_B 0/7] Fix relocatable links with SFrame section
> https://inbox.sourceware.org/binutils/20250407002559.6593-1-indu.bhagat@oracle.com/

The whole series looks good to me in general.

> Indu Bhagat (8):
>   include: libsframe: add APIs for SFrame header flags
>   libsframe: refactor code for dumping section flags
>   include: libsframe: add APIs for offsetof FDE func start addr field
>   include: sframe: doc: define new flag
>     SFRAME_F_FDE_FUNC_START_ADDR_PCREL
>   objdump, readelf: sframe: apply relocations before textual dump
>   bfd: gas: ld: libsframe: adopt new encoding for FDE func start addr
>     field
>   ld: bfd: sframe: fix incorrect r_offset in RELA entries
>   NEWS: sframe: mention new semantics for SFrame FDE function start addr
> 
> Jens Remus (1):
>   ld: bfd: sframe: Update section size also for relocatable links

Thanks for taking the patch as part of your series.

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/