[PATCH, V3 5/6] libsframe: stop search for SFrame FRE if its start IP is greater than PC

[Jens Remus]

On 06.06.2025 12:11, Jan Beulich wrote:
> On 06.06.2025 12:03, Jens Remus wrote:
>> On 06.06.2025 11:29, Jan Beulich wrote:

>>> The removal of these two local vars looks unrelated. I won't insist on this
>>> being moved to a separate patch, but the change then wants mentioning in the
>>> description (to at least make clear it's deliberate, not a mistake).
>>
>> The removal is related, as below (re-cited) change removes the only user
>> of mask_p, making it necessary to remove it.  This in turn removes the
>> only user of fde_type, making it necessary to remove that as well.
> 
> Oh, I see, I overlooked that. I had looked for only fde_type uses, and
> there were none that were removed from the code below.
> 
>> Given Indu has already committed the patch to mainline (presumably as
>> libsframe maintainer) I can no longer amend the description.  Sorry!
> 
> Yeah, I only later noticed these went in already. Given my oversight this
> is fine as is anyway.

I really value your feedback, as it will help me improve my patches in
the future.

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/