[PATCH 0/6] gas: scfi: aarch64: support split sp update pattern

[Alice Carlotti]

On Thu, Aug 08, 2024 at 08:38:47AM -0700, Indu Bhagat wrote:
> Hi,
> 
> This series adds support for the following code pattern in SCFI:
> 
>    mov reg, imm
>    add sp, sp, reg
> 
> This task was tracked by the testcase scfi-unsupported-1.s.
> 
> More details about the changes and design in the respective commit logs.
> 
> Thanks,
> Indu Bhagat (6):
>   gas: ginsn: allow target-specific initialization
>   gas: ginsn: add new ginsn_cofi_p function
>   gas: aarch64: ginsn: add safeguards for reg-based stack pointer update
>   gas: scfi: allow scratch reg state to track values as well
>   gas: scfi: allow additional workflow for split sp update code pattern
>   gas: aarch64: testsuite: add testcases for split sp update code
>     pattern

Hi,

I noticed that there's been no follow-up on this patch series since August -
what's the situation now?

The concept looks reasonable to me, but I have some comments on a couple of
patches.

Alice

> 
>  gas/config/tc-aarch64-ginsn.c                 | 113 +++++++-
>  gas/config/tc-aarch64.h                       |   3 +
>  gas/ginsn.c                                   |  20 ++
>  gas/ginsn.h                                   |   2 +
>  gas/scfi.c                                    | 247 ++++++++++++++++--
>  .../gas/scfi/aarch64/scfi-aarch64.exp         |   4 +-
>  gas/testsuite/gas/scfi/aarch64/scfi-diag-4.l  |   3 +
>  gas/testsuite/gas/scfi/aarch64/scfi-diag-4.s  |  15 ++
>  gas/testsuite/gas/scfi/aarch64/scfi-diag-5.l  |   3 +
>  gas/testsuite/gas/scfi/aarch64/scfi-diag-5.s  |  14 +
>  .../gas/scfi/aarch64/scfi-static-stack-1.d    |  33 +++
>  .../gas/scfi/aarch64/scfi-static-stack-1.l    |   2 +
>  ...-unsupported-1.s => scfi-static-stack-1.s} |  23 +-
>  .../gas/scfi/aarch64/scfi-unsupported-1.l     |   4 -
>  14 files changed, 439 insertions(+), 47 deletions(-)
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-4.l
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-4.s
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-5.l
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-diag-5.s
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-static-stack-1.d
>  create mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-static-stack-1.l
>  rename gas/testsuite/gas/scfi/aarch64/{scfi-unsupported-1.s => scfi-static-stack-1.s} (54%)
>  delete mode 100644 gas/testsuite/gas/scfi/aarch64/scfi-unsupported-1.l
> 
> -- 
> 2.43.0
>