[PATCH] strip: Don't check target_defaulted in input BFD
Jan Beulich
jbeulich@suse.com
Thu Jul 31 06:08:53 GMT 2025
On 31.07.2025 02:44, H.J. Lu wrote:
> On Wed, Jul 30, 2025 at 5:16 PM Alan Modra <amodra@gmail.com> wrote:
>> On Wed, Jul 30, 2025 at 09:02:51AM -0700, H.J. Lu wrote:
>>> diff --git a/binutils/testsuite/binutils-all/x86-64/pr33230.obj.bz2 b/binutils/testsuite/binutils-all/x86-64/pr33230.obj.bz2
>>> new file mode 100644
>>> index 0000000000000000000000000000000000000000..6309a2ad810bce05aea0ef594832ee2b974c87c2
>>> GIT binary patch
>>> literal 411
>>> zcmV;M0c8F{T4*^jL0KkKS!8+Sk^li+|L*_({7vNNd=N{;8bH5q-f+MGKmb61KmY+i
>>> zAONrdRtq92i5^oYsiuaS0000027uE*Xw5+s^%)u`sir}ufEqLa02%?H002m$Ca0)9
>>> zAk#shXwyNU0NR0|27qW3&Q&S^)HcYH35Blu3_)HA)`6CZi~vSKkYJ@)SUQK6P)>9D
>>> zF^y~~*G?x_1vd8WaOee5gP%uQK`XMsG0Bf+<eIG@BErL(v?ORj7J)CfU8FVxVp|Y_
>>> zOCZ6v#chH!nhT90hIo5kz2|)K+E?dTEkd<^U(6r5`IAGO9N{Ch*6DHz>z2e9dqHN}
>>> zDTtL;P{Ni@z>HvG$wP?DXiCJ28VRJS5wwbp$9gh}Cb*4^`j$`xt?@{9ZNj0%9TX`I
>>> z;RB26zDJixQAmr$c@;#H6Jw_Zx7<&9$~aJc3HSjvc3lt$$A^xz^p*h$k3%s=Vh|lY
>>> zJnCyBBs0i-<ugb`1%XqMqzomB>VhnV#RwND3<#?Y10YvgX|NP`NFhIe7ji{7P>^JK
>>> F<dVJ@tX2R3
>>>
>>> literal 0
>>> HcmV?d00001
>>>
You once again were very quick with committing. I have to admit that I
sincerely dislike such testcases. Not only are they almost necessarily
limited to a single architecture (which is pretty inappropriate for a
case like the one here); what's worse, the description doesn't even
say how it was made or why it needs to be in binary form. What if such
a testcase later needs modifying? The very least that I'd like to ask
is that - since the commit message now can't be changed anymore - you
add a comment to binutils/testsuite/binutils-all/x86-64/x86-64.exp,
covering the omissions mentioned above.
Jan
More information about the Binutils
mailing list