[PATCH] ld: testsuite: Fix "PR ld/28138 (build only)" on Solaris
Rainer Orth
ro@CeBiTec.Uni-Bielefeld.DE
Mon Jul 28 14:38:29 GMT 2025
Hi Jan,
>> While it seems weird that the same files are opened twice for reading,
>> it's no wonder that 20 fds aren't enough on Solaris.
>
> The double opening is odd, but looks to be unrelated to the issue at hand
> though?
certainly, it only exacerbates the out-of-fds issue. Without it, the
test would most likely have PASSed on Solaris with the original fd limit
already.
>> To avoid this, I've raised the limit to 25, hoping that this will be
>> enough on more targets.
>
> That's okay, yes, but the patch description wants to be non-empty. (The way
> you submit patches it remains unclear how the final patch that you mean to
> commit would look like.)
The description is supposed to be exactly the body of the mail (minus
the "Ok for trunk?" part and the signature.
I often write the full description only when done with the patch proper,
extracting the gist from my notes. Updating that patch with that is
just double work when I can easily extract it from the mail. I've
worked this way for years (decades?) in all of gcc, gdb, and binutils,
so far without complaints ;-)
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
More information about the Binutils
mailing list