[PATCH v2] gas: add missing header guard in tc-<arch>.h files

Matthieu Longo matthieu.longo@arm.com
Fri Jul 25 09:24:13 GMT 2025


On 2025-07-15 07:56, Jan Beulich wrote:
> On 14.07.2025 17:29, Matthieu Longo wrote:
>> This patch adds missing header guards in some of the tc-<arch>.h, and
>> does not aim at being exhaustive. It only touched some files relevant
>> for [1].
>>
>> [1]: https://inbox.sourceware.org/binutils/20250711112913.2453285-1-matthieu.longo@arm.com/
> 
> For some of the files touched, it doesn't add guards but merely comments
> on the corresponding #endif. The patch looks okay to me now, but the
> description may still want amending some. Please give target maintainers
> a week to chime in, before you commit.
> 
> Jan

Hi Jan,

I am planning to change the commit description to the below:

This patch adds missing header guards in some of the tc-<arch>.h, and 
merely comments on the corresponding #endif for others. The patch does 
not aim at being exhaustive, it only touched the files relevant for [1].

[1]: 
https://inbox.sourceware.org/binutils/20250711112913.2453285-1-matthieu.longo@arm.com/


A week has gone, and no maintainer commented on the patch, what should I 
do now ? Since I have your approval, is it acceptable to consider the 
patch good to be merged with the amending of the description to the above ?

Matthieu


More information about the Binutils mailing list