PR 21497 supplemental patch

[Sam James]

Nick Clifton <nickc@redhat.com> writes:

> Hi HJ, Hi Sam,

Hi Nick,

>
>   We have recently run across a problem in Fedora building LLVM:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=2382341
>
>   I have traced the problem back to the fact that strip will now load a
>   plugin to handle GCC LTO data in archive members (ie PR 21479).
>   This is great unless the plugin fails to recognise the archive member,
>   because if that happens strip will stop with an unrecognised format
>   error message, rather than continuing to process other elements.
>
>   So I would like to propose a small change to the current code.  The
>   patch below first tries opening the element with the "plugin" target,
>   but if that fails, it carries on to try to open the element normally.
>
>   This solves the problem reported in BZ 2382341 and seems to make sense
>   to me.  Do either of you have any concerns with me applying this patch
>   ?
>

Thanks for checking. Always appreciated but especially here because this
functionality is something we really needed. I'll think it through and
also run it through the tests I wrote for this either today or tomorrow.

> Cheers
>   Nick

thanks,
sam

> [...]