[PATCH] gprofng: do not skip weak symbols

[Vladimir Mezentsev]

On 7/19/25 05:23, Dmitrii Bordukov wrote:
> I'm sorry, I don't have push permissions to repo. I have Sourceware 
> Bugzilla account only.
> It is my very first patch outside github, so I do not grasp the 
> contributing process very well.
>


Pushed to the master branch.

Is it OK for 2.45 ?

-Vladimir



On 7/19/25 05:21, Dmitrii Bordukov wrote:
> PR gprofng/33151
>
> gprofng ignores functions that are compiled as weak symbols. This
> heavily affects C++ class methods that are always compiled by g++
> and clang++ as weak symbols. In this case 'gprofng display text'
> just displays <static>@ADDRESS(<FILENAME>) instead of proper method
> name.
>
> The bug has been introduced in the commit 470a0288a818.
> ---
>   gprofng/src/Stabs.cc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gprofng/src/Stabs.cc b/gprofng/src/Stabs.cc
> index 116316ed5b6..20bdf8ba663 100644
> --- a/gprofng/src/Stabs.cc
> +++ b/gprofng/src/Stabs.cc
> @@ -1546,7 +1546,7 @@ Stabs::readSymSec (Elf *elf, bool is_dynamic)
>         switch (GELF_ST_TYPE (Sym.st_info))
>   	{
>   	case STT_FUNC:
> -	  if (Sym.st_size == 0 || ELF_ST_BIND (Sym.st_info) == STB_WEAK)
> +	  if (Sym.st_size == 0)
>   	    break;
>   	  if (Sym.st_shndx == 0)
>   	    {