[PATCH v1] gas: add missing header guard in tc-<arch>.h files

Jan Beulich jbeulich@suse.com
Mon Jul 14 14:46:54 GMT 2025


On 14.07.2025 16:37, Matthieu Longo wrote:
> --- a/gas/config/tc-arc.h
> +++ b/gas/config/tc-arc.h
> @@ -272,3 +272,5 @@ extern void arc_md_end (void);
>  #define md_end arc_md_end
>  
>  #endif
> +
> +#endif /* TC_ARC */

This, ...

> --- a/gas/config/tc-csky.h
> +++ b/gas/config/tc-csky.h
> @@ -107,3 +107,5 @@ const char * elf32_csky_target_format (void);
>  #endif
>  
>  #endif
> +
> +#endif /* TC_CSKY */

... this, and

> --- a/gas/config/tc-sparc.h
> +++ b/gas/config/tc-sparc.h
> @@ -179,3 +179,5 @@ extern int sparc_cie_data_alignment;
>  #define CFI_DIFF_EXPR_OK 0
>  
>  #endif
> +
> +#endif /* TC_SPARC */

... this don't look right: You add #endif but no corresponding #if. Plus they
all already have #ifdef TC_... at their top, so I wonder what these changes
are about. Did you maybe mean to add comments to the existing #endif-s?

Plus, as indicated, for changes to tc-* files you want to Cc their maintainers,
as its preferably them who would approve changes there. (The changes here are
likely easy enough that this isn't overly important, but still.)

Jan


More information about the Binutils mailing list