s390x sframe regressions

[Andreas Krebbel]

Hi Alan, Hi Jens,

On 7/14/25 12:34 PM, Jens Remus wrote:
> On 14.07.2025 12:07, Alan Modra wrote:
>> Recent patches have resulted in regressions.
>> s390x-linux-gnu  FAIL: LTO 4a
>> s390x-linux-gnu  FAIL: LTO 4c
>> s390x-linux-gnu  FAIL: LTO 4d
>> s390x-linux-gnu  FAIL: SFrame simple link
>> s390x-linux-gnu  FAIL: SFrame for plt0 and pltN
>>
>> 	* elf64-s390.c (elf_s390_create_dynamic_sections): Set plt_sframe
>> 	ELF section type.
> Alan,
> thank you very much for fixing the regression!  I have verified that
> your patch resolves the issue introduced by Indu's recent commit
> 6ab3f09a682a ("gas: elf: binutils: add new section type SHT_GNU_SFRAME").
> This was a minor oversight, given the s390x SFrame support is very new.
>
> Could you please reference that commit in your patch description,
> to ease future understanding of the root cause for the regression?
>
>> OK?
> Andreas,
> could you please approve for s390?

Ok, approved. Thank you, Alan!


Andreas

>
>> diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c
>> index d801848df4a..a79cc476572 100644
>> --- a/bfd/elf64-s390.c
>> +++ b/bfd/elf64-s390.c
>> @@ -4299,6 +4299,8 @@ elf_s390_create_dynamic_sections (bfd *dynobj,
>>   								 flags);
>>   	  if (htab->plt_sframe == NULL)
>>   	    return false;
>> +
>> +	  elf_section_type (htab->plt_sframe) = SHT_GNU_SFRAME;
>>   	}
>>       }
> Reviewed-by: Jens Remus <jremus@linux.ibm.com>
>
> Thanks and regards,
> Jens