[PATCH] Remove AM_PO_SUBDIRS from configure.ac

[Alan Modra]

On Thu, Jul 10, 2025 at 10:56:58PM -0400, Pietro Monteiro wrote:
> On Thu, Jul 10, 2025, at 9:15 AM, Alan Modra wrote:
> > AC_REQUIRE doesn't care about conditionals.  The result of Pietro's
> > patch will be the same as swapping the order of AM_PO_SUBDIRS and
> > ZW_GNU_GETTEXT_SISTER_DIR invocations.  I favour doing that rather
> > than deleting AM_PO_SUBDIRS.
> 
> I guess that's a matter of taste :) . I think the AM_PO_SUBDIRS is
> redundant, which is why I removed it. I just checked the rest of the
> tree and GCC and the files in this patch are the only ones that have
> AM_PO_SUBDIRS.

I agree that AM_PO_SUBDIRS is redundant.  I left it in because I
didn't want to dig through the history to see why it was there in the
first place.  Now that I have looked and seen commit 862776f26a59,
I feel happier about removing it.

diff --git a/bfd/configure.ac b/bfd/configure.ac
index 5879a04785d..1e918e3b0aa 100644
--- a/bfd/configure.ac
+++ b/bfd/configure.ac
@@ -207,7 +207,6 @@ bfd_default_target_size=32
 # host stuff:
 
 ALL_LINGUAS="da es fi fr hr id ja ro ru rw sr sv tr uk vi zh_CN pt"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 # Permit host specific settings.
@@ -1040,8 +1039,7 @@ esac
 
 AC_CONFIG_FILES([Makefile bfd-in3.h:bfd-in2.h po/Makefile.in:po/Make-in])
 
-dnl We need this duplication, even though we use AM_PO_SUBDIRS, because of
-dnl our two separate POTFILES.  Yuck.
+dnl We need this duplication because of our two separate POTFILES.
 AC_CONFIG_COMMANDS([default],
 [[
 case "$srcdir" in
diff --git a/binutils/configure.ac b/binutils/configure.ac
index cb65e503df1..a3930363b3f 100644
--- a/binutils/configure.ac
+++ b/binutils/configure.ac
@@ -156,7 +156,6 @@ AC_PROG_YACC
 AM_PROG_LEX
 
 ALL_LINGUAS="bg ca da es fi fr hr id it ja pt ro ru rw sk sr sv tr uk vi zh_CN zh_TW"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 AM_MAINTAINER_MODE
diff --git a/gas/configure.ac b/gas/configure.ac
index 30fa5eb13ea..c65797fdf0a 100644
--- a/gas/configure.ac
+++ b/gas/configure.ac
@@ -941,7 +941,6 @@ AC_PROG_YACC
 AM_PROG_LEX
 
 ALL_LINGUAS="es fi fr id ja ru rw sv tr uk zh_CN"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 AM_MAINTAINER_MODE
diff --git a/gold/configure.ac b/gold/configure.ac
index ee962b9c65d..90e51de3046 100644
--- a/gold/configure.ac
+++ b/gold/configure.ac
@@ -313,7 +313,6 @@ AC_PROG_RANLIB
 AC_PROG_INSTALL
 AC_PROG_LN_S
 
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 AC_C_BIGENDIAN
diff --git a/gprof/configure.ac b/gprof/configure.ac
index a32bf9399c4..94486ed1af5 100644
--- a/gprof/configure.ac
+++ b/gprof/configure.ac
@@ -43,7 +43,6 @@ AC_CHECK_HEADERS(sys/time.h)
 AC_CHECK_FUNCS(setitimer)
 
 ALL_LINGUAS="bg da de eo es fi fr ga hu id it ja ms nl pt_BR ro ru rw sr sv tr uk vi"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 AM_MAINTAINER_MODE
diff --git a/ld/configure.ac b/ld/configure.ac
index 5476d30f7dc..b8241febc2e 100644
--- a/ld/configure.ac
+++ b/ld/configure.ac
@@ -388,7 +388,6 @@ fi
 # host-specific stuff:
 
 ALL_LINGUAS="bg da de es fi fr ga id it ja pt_BR ru sr sv tr uk vi zh_CN zh_TW"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 AC_EXEEXT
diff --git a/opcodes/configure.ac b/opcodes/configure.ac
index e31ddde9e57..783ac2a7a7a 100644
--- a/opcodes/configure.ac
+++ b/opcodes/configure.ac
@@ -86,7 +86,6 @@ AC_EXEEXT
 # host-specific stuff:
 
 ALL_LINGUAS="da de es fi fr ga id it nl pt_BR ro sr sv tr uk vi zh_CN"
-AM_PO_SUBDIRS
 ZW_GNU_GETTEXT_SISTER_DIR
 
 . ${srcdir}/../bfd/configure.host


-- 
Alan Modra