[PATCH v2] gas: support --gsframe=no
Jan Beulich
jbeulich@suse.com
Mon Jul 14 06:30:10 GMT 2025
On 11.07.2025 18:45, Sam James wrote:
> @@ -1038,7 +1039,15 @@ This program has absolutely no warranty.\n"));
> break;
>
> case OPTION_SFRAME:
> - flag_gen_sframe = 1;
> + if (optarg)
> + if (strcasecmp (optarg, "no") == 0)
> + flag_gen_sframe = 0;
> + else if (strcasecmp (optarg, "yes") == 0)
> + flag_gen_sframe = 1;
> + else
> + as_fatal (_("Invalid --gsframe option: `%s'"), optarg);
> + else
> + flag_gen_sframe = 1;
> break;
Nit: Can we please have braces separating the inner if() sequence from the
outer one? (Assuming the discussion with Indu can be settled regarding the
default - aiui it's "no", as you say - this is then fine to put in.
Ideally with doc updated accordingly as well.)
Jan
More information about the Binutils
mailing list