[PATCH v2] gas: Move gas_sframe_check to binutils-common.exp

[H.J. Lu]

On Mon, Jul 14, 2025 at 7:01 AM Indu Bhagat <indu.bhagat@oracle.com> wrote:
>
> On 7/13/25 3:10 PM, H.J. Lu wrote:
> > On Mon, Jul 14, 2025 at 6:01 AM Alan Modra <amodra@gmail.com> wrote:
> >>
> >> On Mon, Jul 14, 2025 at 05:17:45AM +0800, H.J. Lu wrote:
> >>> On Mon, Jul 14, 2025 at 5:15 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >>>> Here is the v2 patch to replace gas_host_run with remote_exec so
> >>>> that it can be used in ld tests.
> >>>>
> >>>
> >>> Oops.  Wrong patch.  Here is the right one.
> >>
> >> OK.
> >>
> >>> +    if { ![string match "" $comp_output]
> >>> +      || [string match "*sframe not supported for target*" $comp_output] } then {
> >>
> >> May as well fix this redundant check while you're at it.
> >
> > Sure.  I will check the patch with
> >
> >      set output_file "tmpdir/check_as_sframe.out"
> >      set status [remote_exec host "$AS $ASFLAGS $as_file" "2> $output_file"]
>
> I am seeing failures with the committed patch.
>
> It looks like some tests have --gsframe unexpectedly too ?

I got
FAIL: CFI on x86-64
FAIL: CFI on i386
FAIL: CFI on i386, 2
FAIL: .cfi_label directive
FAIL: cfi listing
FAIL: CFI common 1
FAIL: CFI common 2
FAIL: CFI common 3
FAIL: CFI common 4
FAIL: CFI common 5
FAIL: CFI common 7
FAIL: CFI common 8
FAIL: DWARF .debug_line 1
FAIL: DWARF .debug_line 2
FAIL: DWARF .debug_line 4
FAIL: DWARF2 debugging information 2
FAIL: DWARF2 debugging information 2 with SHF_COMPRESSED
FAIL: CFI common 1
FAIL: CFI common 2
FAIL: CFI common 3
FAIL: CFI common 4
FAIL: CFI common 5
FAIL: CFI common 6
FAIL: CFI common 7
FAIL: CFI on x86-64
FAIL: gas/i386/ehinterp
FAIL: SCFI no ignore .cfi_label
FAIL: x86_64 scfi-cfi-label-1
FAIL: Empty SFrame section
FAIL: ld-x86-64/pr27016a
FAIL: ld-x86-64/pr27016b
FAIL: PR ld/20830 (.plt.got)
FAIL: PR ld/20830 (.plt.got) (x32)
FAIL: PR ld/20830 (.plt.got, -z now)
FAIL: PR ld/20830 (.plt.got, -z now) (x32)
FAIL: ld-x86-64/ibt-plt-1-x32
FAIL: ld-x86-64/ibt-plt-2a
FAIL: ld-x86-64/ibt-plt-2b
FAIL: ld-x86-64/ibt-plt-2a-x32
FAIL: ld-x86-64/ibt-plt-2b-x32
FAIL: ld-x86-64/ibt-plt-2c-x32
FAIL: ld-x86-64/ibt-plt-2d-x32
FAIL: ld-x86-64/ibt-plt-3a
FAIL: ld-x86-64/ibt-plt-3b
FAIL: ld-x86-64/ibt-plt-3a-x32
FAIL: ld-x86-64/ibt-plt-3b-x32
FAIL: ld-x86-64/ibt-plt-3c-x32
FAIL: ld-x86-64/ibt-plt-3d-x32

How about this?



> >      set comp_output [file_contents "$output_file"]
> >      set ASFLAGS "$old_ASFLAGS"
> >
> >      if { ![string match "" $comp_output] } then {
> >          verbose -log "SFrame not supported in AS"
> >          return 0
> >      } else {
> >          verbose -log "SFrame supported in AS"
> >          return 1
> >      }
>
>
>


--
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gas_sframe_check-Properly-output-in-remote_exec.patch
Type: text/x-patch
Size: 1096 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20250714/54aeb189/attachment.bin>