[PATCH v2] gas: Move gas_sframe_check to binutils-common.exp

[Indu Bhagat]

On 7/13/25 4:13 PM, Alan Modra wrote:
> On Mon, Jul 14, 2025 at 06:10:16AM +0800, H.J. Lu wrote:
>>      set output_file "tmpdir/check_as_sframe.out"
>>      set status [remote_exec host "$AS $ASFLAGS $as_file" "2> $output_file"]
>>      set comp_output [file_contents "$output_file"]
>>      set ASFLAGS "$old_ASFLAGS"
>>
>>      if { ![string match "" $comp_output] } then {
>>          verbose -log "SFrame not supported in AS"
>>          return 0
>>      } else {
>>          verbose -log "SFrame supported in AS"
>>          return 1
>>      }
> 
> Something went wrong in your testing of this patch.
> 
> Running /home/alan/src/binutils-gdb/gas/testsuite/gas/cfi-sframe/cfi-sframe.exp ...
> ERROR: tcl error sourcing /home/alan/src/binutils-gdb/gas/testsuite/gas/cfi-sframe/cfi-sframe.exp.
> ERROR: tcl error code POSIX ENOENT {no such file or directory}
> ERROR: couldn't open "tmpdir/check_as_sframe.out": no such file or directory
>      while executing
> "open $filename r"
>      (procedure "file_contents" line 2)
>      invoked from within
> "file_contents "$output_file""
>      (procedure "gas_sframe_check" line 29)
>      invoked from within
> "gas_sframe_check"
>      invoked from within
> "if  { ([istarget "x86_64-*-*"] || [istarget "aarch64*-*-*"]
>         || [istarget "s390x-*-*"]) \
>        && [gas_sframe_check] } then {
> 
> I'm testing a fix.
> 

-    set status [remote_exec host "$AS $ASFLAGS $as_file" "2> $output_file"]
+    set status [remote_exec host $AS $ASFLAGS $as_file $output_file]

seems to work for me