[PATCH,V2 2/3] libsframe: bump version to 2.0

[Indu Bhagat]

On 7/10/25 12:26 AM, Jan Beulich wrote:
> On 09.07.2025 22:06, Indu Bhagat via Binutils wrote:
>> Create a new LIBSFRAME_2.0 entry (non-inheritance version) to create new
>> global versioned symbols.
>>
>> New APIs:
>>       sframe_decoder_get_flags;
>>       sframe_decoder_get_offsetof_fde_start_addr;
>>       sframe_encoder_get_flags;
>>       sframe_encoder_get_offsetof_fde_start_addr;
>>
>> Removed APIs: (already deprecated since X-2 release)
>>       sframe_get_funcdesc_with_addr;
>>
>> APIs with changed semantics:
>>       sframe_decoder_get_funcdesc_v2;
>>       sframe_encoder_add_funcdesc_v2;
>>       sframe_encoder_write;
>>
>> lisbframe/
>> 	* libsframe.ver: Define new LIBSFRAME_2.0.
>> 	* libtool-version: Bump the 'current' numeral to indicate a binary
>> 	incompatible release.
>> include/
>> 	* sframe-api.h (sframe_get_funcdesc_with_addr): Remove
>> 	deprecated interface.
>> libsframe/
>> 	* sframe.c (sframe_get_funcdesc_with_addr): Likewise.
>> ---
>>   include/sframe-api.h      |  8 --------
>>   libsframe/libsframe.ver   | 40 +++++++++++++++++++++++++++++++++++++--
>>   libsframe/libtool-version |  2 +-
>>   libsframe/sframe.c        | 12 ------------
>>   4 files changed, 39 insertions(+), 23 deletions(-)
> 
> Hmm, while you folded the two patches, you still didn't ...
> 
>> --- a/include/sframe-api.h
>> +++ b/include/sframe-api.h
>> @@ -153,14 +153,6 @@ sframe_decoder_get_fixed_fp_offset (sframe_decoder_ctx *dctx);
>>   extern int8_t
>>   sframe_decoder_get_fixed_ra_offset (sframe_decoder_ctx *dctx);
>>   
>> -/* Find the function descriptor entry which contains the specified address.
>> -
>> -   Note: This function is deprecated and will be removed from future release
>> -   X+2 of the library.  */
>> -extern void *
>> -sframe_get_funcdesc_with_addr (sframe_decoder_ctx *dctx, int32_t addr,
>> -			       int *errp);
> 
> ... represent this removal ...
> 
>> --- a/libsframe/libsframe.ver
>> +++ b/libsframe/libsframe.ver
>> @@ -39,9 +39,45 @@ LIBSFRAME_1.0 {
>>       *;
>>   } LIBSFRAME_0.0;
> 
> ... in the 1.0 section up from here. (I'm surprised the linker doesn't at least
> warn when an entry in the export list isn't defined anywhere.)
> 

Ah I should have removed the LIBSFRAME_1.0 node completely. (Apologies, 
I have had this versioning patch in my work branches where I tested it, 
something got messed up when bringing it in a separate branch for 
posting these patches as set.)

Yeah, the linker does not complain if there is an entry in version 
script, but not defined.  I had dump_sframe_reloc in LIBSFRAME_2.0 node. 
I have removed it.

Thanks