[PATCH] Remove AM_PO_SUBDIRS from configure.ac
Alan Modra
amodra@gmail.com
Thu Jul 10 13:15:18 GMT 2025
On Thu, Jul 10, 2025 at 09:17:33AM +0200, Jan Beulich wrote:
> On 10.07.2025 03:34, Pietro Monteiro wrote:
> > Some configure.ac files use both AM_PO_SUBDIRS and
> > ZW_GNU_GETTEXT_SISTER_DIR macros. In-tree gettext build support
> > requires ZW_GNU_GETTEXT_SISTER_DIR, which also indirectly AC_REQUIRE's
> > AM_PO_SUBDIRS, causing double expansion.
>
> Yet the invocation of AM_GNU_GETTEXT() is conditional in
> ZW_GNU_GETTEXT_SISTER_DIR(). What about the other path there?
AC_REQUIRE doesn't care about conditionals. The result of Pietro's
patch will be the same as swapping the order of AM_PO_SUBDIRS and
ZW_GNU_GETTEXT_SISTER_DIR invocations. I favour doing that rather
than deleting AM_PO_SUBDIRS.
>
> Not being overly familiar with autoconf, "double expansion" of what
> specifically? Causing what kind of problem?
No problem, just duplicate code in configure.
> Jan
>
> > Remove the direct uses of
> > AM_PO_SUBDIRS to get rid of the duplicated code.
--
Alan Modra
More information about the Binutils
mailing list