[PATCH v5 13/20] Merge of Object Attributes v2 during linkage (generic logic)

[Richard Earnshaw (lists)]

On 09/07/2025 17:47, Matthieu Longo wrote:

>> In this case I'd put the opening parenthesis on the following line, so that you
>> don't lose too much horizontal white space when correctly indenting ...
> 
> Well, this one I am wondering if the medicine is not worse than the disease.
> 
>           _bfd_error_handler
>         (_("%pB: error: found 2 subsections with the same name '%s' and"
>            " found conflicting values (0x%x vs 0x%x) for object "
>            "attribute 'Tag_unknown_%u'"), abfd, subsec1->name,
>            a1->vals.uint_val, a2->vals.uint_val, a1->tag);

This may just be mailer formatting, but I think it should look like

      if (subsec1->encoding == OA_ENC_ULEB128
          && a1->vals.uint_val != a2->vals.uint_val)
        {
           success = false;
           _bfd_error_handler
             (_("%pB: error: found 2 subsections with the same name '%s' "
                "and found conflicting values (0x%x vs 0x%x) for object "
                "attribute 'Tag_unknown_%u'"),
              abfd, subsec1->name, a1->vals.uint_val, a2->vals.uint_val,
              a1->tag);
        }

Adding a line break after the translatable string makes it clear that the arguments are passed to _bfd_error_handler, not the translation.

R.