[PATCH 2/4] libsframe: remove deprecated interface

[Indu Bhagat]

On 7/8/25 1:13 AM, Jan Beulich wrote:
> On 08.07.2025 09:53, Indu Bhagat via Binutils wrote:
>> Soon, libsframe.so.2 will be released.  Remove the already deprecated
>> (since X-2 release) interface.
>>
>> include/
>>          * sframe-api.h (sframe_get_funcdesc_with_addr): Remove
>> 	deprecated interface.
>> libsframe/
>>          * sframe.c (sframe_get_funcdesc_with_addr): Likewise.
>> ---
>>   include/sframe-api.h |  8 --------
>>   libsframe/sframe.c   | 12 ------------
>>   2 files changed, 20 deletions(-)
> 
> Don't you also need to touch libsframe.ver right here?
> 

Yeah.  Perhaps its best to combine this patch with patch 3 "libsframe: 
bump version to 2.0".  We will  have a healthy state with each commit then.

> Whether it is a good idea to remove interfaces is a separate question.
> I generally think such better wouldn't be done, but there may well be
> a good reason here.
> 

This interface was a problematic one (removed early right after SFrame 
V1 release IIRC).  More details from commit 
852bb8c10de8abef79f0771dca879ddc8e4298b3:

     The interface provided by this function is not a healthy abstraction to
     expose: the return type sframe_func_desc_entry, which is defined in
     include/sframe.h (the SFrame binary format definition).  This ties up
     the library in a undesirable way.  Most importantly, this function
     should technically not be directly necessary for a stack tracer.  A
     stack tracer will likely only need to do a sframe_find_fre ().

     Rename the API to continue to use the functionality internally in the
     library.  bfd/linker does not use this function.

Thanks again for reviewing