gas pointer to int and vice versa
Sam James
sam@gentoo.org
Wed Jul 9 16:31:33 GMT 2025
"Maciej W. Rozycki" <macro@orcam.me.uk> writes:
> On Wed, 9 Jul 2025, Alan Modra wrote:
>
>> diff --git a/gas/config/tc-v850.c b/gas/config/tc-v850.c
>> index b3440058756..09411767e7f 100644
>> --- a/gas/config/tc-v850.c
>> +++ b/gas/config/tc-v850.c
>> @@ -3070,7 +3070,7 @@ md_assemble (char *str)
>> f = frag_var (rs_machine_dependent, 6, 2, SUBYPTE_LOOP_16_22,
>> fixups[0].exp.X_add_symbol,
>> fixups[0].exp.X_add_number,
>> - (char *)(size_t) fixups[0].opindex);
>> + (char *)(intptr_t) fixups[0].opindex);
>
> Hmm, given that updates were made to the affected lines this piece and
> the rest of the changes applied to this file could have benefitted from
> fixing formatting to follow the GNU Coding Standards, i.e. adding the
> missing space after the first cast:
>
> (char *) (intptr_t) fixups[0].opindex);
>
> but given that you've pushed it already I think the file will best remain
> as it is so as not to clutter `git blame' with syntactic noise. Sigh.
I think the "Sigh." can come across as passive aggressive and is
unhelpful.
Anyway, there's nothing stopping us maintaining a .git-blame-ignore-revs
file at the root of the repo which contains commits to be ignored for
the purposes of `git blame`. git has to be configured to use it (the
filename isn't special / automatically recognised) but that's not a big
deal.
>
> Maciej
sa
More information about the Binutils
mailing list