[PATCH] gas: ld: sframe: add new internal header

[Indu Bhagat]

On 7/9/25 12:18 AM, Jens Remus wrote:
> Hello Indu!
> 
> thank you for addressing the issue I have run into with my s390x SFrame
> support patch series!
> 
> On 08.07.2025 23:30, Indu Bhagat wrote:
>> for SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS.
>>>> The intention of creating an abstraction like
>> SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS is to address the concern that there
>> should be a central place to enforce harmonious flags between GNU as and
>> ld. At the moment, the only flag that needs to be enforced is
>> SFRAME_F_FDE_FUNC_START_PCREL.
> 
> Wouldn't that also apply to any other assembler and linker?  For example
> LLVM mc and lld?
> 

SFRAME_F_FDE_FUNC_START_PCREL is a special flag in that sense.  Yes, I'd 
expect that the output SFrame sections should have this one set.  With 
the existing set of PC-REL relocations available in the ABIs supported 
in SFrame, the other toolchain will also need to resort to PCREL for 
func start address.

>> sframe.h and sframe-api.h are installed headers by libsframe for the
>> specification and implementation respectively.  Adding a definition like
>> SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS does not fit in either.  Create a
>> new internal header instead to keep the definition uncoupled from
>> sframe.h and sframe-api.h.
> 
> Would it make sense to mention that you are renaming the flag set?
> 

OK. I have added a line:
"Rename the previously added SFRAME_F_LD_MUSTHAVE_FLAGS to define the 
new SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS."

>>
>> bfd/
>>          * elf-sframe.c (_bfd_elf_merge_section_sframe): Use the new
>> 	internal header and SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS.
>> gas/
>>          * gen-sframe.c (output_sframe_internal): Likewise.
>> include/
>>          * sframe-api.h (SFRAME_F_LD_MUSTHAVE_FLAGS): Move from..
>>          * sframe-internal.h: ..to here.  New file.
> 
> 	* sframe-internal.h: ..to here and rename to
> 	SFRAME_V2_GNU_GAS_LD_ENCODING_FLAGS.  New file.
> 
> Nit: It seems you used spaces instead of a tab to indent the
> GNU ChangeLog.
> 

Thanks. I had noticed that and had corrected it along with the tab issue 
Jan pointed out.

Indu