[PATCH v3 02/11] s390: Explicitly list linker dump tests

[Jens Remus]

Indu, Andreas,

just FYI that I will send a V4, as I need to make additional minor
adaptions for the recently committed series "Fix relocatable SFrame
links":

https://inbox.sourceware.org/binutils/20250706230624.99019-1-indu.bhagat@oracle.com/

On 07.07.2025 14:36, Jens Remus wrote:
> On 27.06.2025 13:08, Jens Remus wrote:
>> Generating the linker dump test list using file globbing makes it
>> difficult to exclude specific tests under certain circumstances.  List
>> them explicitly instead.  This enables to add tests in the future that
>> can be excluded.  While at it reorganize how s390 linker tests get
>> run for s390x.
>>
>> ld/testsuite/
>> 	* ld-s390/s390.exp: Reorganize and explicitly list linker dump
>> 	tests.
>>
>> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
>> ---
>>
>> Notes (jremus):
>>     Changes in V3:
>>     - Drop unnecessary parenthesis from expression.
> 
> Could you please review this s390-specific patch and approve the whole
> series from an s390 point-of-view, so that the s390x SFrame support
> can make it for Binutils 2.45.
> 
> Indu (SFrame Maintainer) has approved all other patches from an SFrame
> point-of-view, provided that I apply some minor corrections.  I am on
> it.  :-)
> 
> This specific change is needed, so that SFrame linker tests added with
> patches "[PATCH v3 03/11] s390: Initial support to generate .sframe from
> CFI directives in assembler" and "[PATCH v3 06/11] s390: Add SFrame
> stack trace information for .plt section" can be excluded from being run
> when SFrame is not supported (same logic as on AArch64 and x86-64).
> 
>>
>>  ld/testsuite/ld-s390/s390.exp | 15 ++++++---------
>>  1 file changed, 6 insertions(+), 9 deletions(-)
>>
>> diff --git a/ld/testsuite/ld-s390/s390.exp b/ld/testsuite/ld-s390/s390.exp
>> index aaba88d512ab..e5bfb511ff61 100644
>> --- a/ld/testsuite/ld-s390/s390.exp
>> +++ b/ld/testsuite/ld-s390/s390.exp
>> @@ -135,18 +135,15 @@ set s390xtests {
>>       "pr32969_64-2"}
>>  }
>>  
>> -if [istarget "s390-*-*"] {
>> +if { [istarget "s390-*-*"] || [istarget "s390x-*-*"] } {
>>      run_ld_link_tests $s390tests
>> +
>> +    run_dump_test "pr26918-1"
>> +    run_dump_test "reloccheck-1"
>> +    run_dump_test "reloctlsle-1"
>> +
>>  }
>>  
>>  if [istarget "s390x-*-*"] {
>> -    run_ld_link_tests $s390tests
>>      run_ld_link_tests $s390xtests
>>  }
>> -
>> -set test_list [lsort [glob -nocomplain $srcdir/$subdir/*.d]]
>> -foreach t $test_list {
>> -    # We need to strip the ".d", but can leave the dirname.
>> -    verbose [file rootname $t]
>> -    run_dump_test [file rootname $t]
>> -}
> 
> Thanks and regards,
> Jens

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/