[PATCH 1/3] gas: sframe: guard block with support_sframe_p

Jan Beulich jbeulich@suse.com
Mon Jul 7 06:19:39 GMT 2025


On 07.07.2025 08:10, Indu Bhagat via Binutils wrote:
> SFrame is generated for ELF targets only.  Guard the block with
> support_sframe_p like others for consistency.

The block was guarded already, just not ...

> @@ -2606,6 +2601,7 @@ cfi_finish (void)
>  	- .sframe in the .cfi_sections directive.  */
>    if (flag_gen_sframe || (all_cfi_sections & CFI_EMIT_sframe) != 0)
>      {
> +#ifdef support_sframe_p

... by a pre-processor conditional, just ...

>        if (support_sframe_p () && !SUPPORT_FRAME_LINKONCE)

... the invocation (plus the stub that you now remove). Hence the
description doesn't really make clear what the problem as and why a
change would be needed.

Jan


More information about the Binutils mailing list