[PATCH PR gas/33030] gas: accept leading zeros on dollar local labels in z80 sdcc compat mode
Jan Beulich
jbeulich@suse.com
Sun Jul 6 09:58:57 GMT 2025
On 05.07.2025 02:01, Maciej W. Rozycki wrote:
> On Fri, 4 Jul 2025, Aaron Griffith wrote:
>
>> Worth noting, the commit that first broke SDCC compatibility did run the
>> z80 tests and saw the test failure. They just modified the test to pass.
>
> Weird, the need to adjust a testcase should have been a red flag!
I indeed was surprised to find something like that. Without things being
explained anywhere that I could sensibly spot, I could only take it as
"odd", and hope for someone to reply to the patch submission if they knew
more than I did. _That_ imo is the main problem - patches aren't being
looked at while they're still uncommitted. (The situation is of course
generally worse for targets without any maintainers.)
Jan
More information about the Binutils
mailing list