[PATCH PR gas/33030] gas: accept leading zeros on dollar local labels in z80 sdcc compat mode

Maciej W. Rozycki macro@orcam.me.uk
Fri Jul 4 23:57:53 GMT 2025


On Fri, 4 Jul 2025, H.J. Lu wrote:

> > I'm not sure what more to test -- there is already a test for normal use
> > of dollar local labels in gas/testsuite/gas/z80/dollar.s.
> 
> Most of developers don't run this test.

 Then their workflow is wrong for making changes to generic parts of 
binutils, as their verification should cover all the targets that can be 
reasonably tested.

 It takes my development system only ~1h to verify across 239 targets and
that's a pessimistic figure, as my MIPS set of targets included in the 
whole set is over represented at 101 individual configuration triplets.  
The list does include `z80-coff' and `z80-elf', and I try to keep the list 
up to date by monitoring targets being added and removed.

 I don't say random Joe developer making a one-off submission to binutils 
is supposed to run such verification, but a maintainer accepting such a 
change ought to, as should a regular contributor.

  Maciej


More information about the Binutils mailing list