[PATCH] gas: support --gsframe=no

[Sam James]

Jan Beulich <jbeulich@suse.com> writes:

> On 04.07.2025 03:40, Sam James wrote:
>> Being able to explicitly disable SFrames on the command line is useful,
>> especially when looking at a gas that enables SFrames by default. The
>> binutils testsuite will benefit from this as there's testcases that don't
>> expect their presence.
>> 
>> 	PR gas/33125
>> 	* gas/as.c (parse_args): Accept --gsframe=no, --gsframe=yes.
>> ---
>> If needed, I can change this to --no-gsframe, but this seems to be
>> the more common form (and I prefer this one, mildly).
>
> Same here.
>
>> --- a/gas/as.c
>> +++ b/gas/as.c
>> @@ -311,7 +311,9 @@ Options:\n\
>>    fprintf (stream, _("\
>>                            generate GNU Build notes if none are present in the input\n"));
>>    fprintf (stream, _("\
>> -  --gsframe               generate SFrame stack trace information\n"));
>> +  --gsframe=[no|yes] "));
>> +  fprintf (stream, _("\
>> +                          generate SFrame stack trace information\n"));
>
> I think it would be nice if help output made clear that the form without
> argument is also still supported. It further looks as if the verbal part
> may want a little bit of an adjustment, albeit I notice that the text for
> e.g. --elf-stt-common or --generate-missing-build-notes is similarly
> worded only the "positive" way. Personally I'd add e.g. "whether to".

Ack. I'll tweak that locally and then await more comments before posting
again. Thanks for the quick review.

>
> Jan

sam