[PATCH v2 01/65] gas: consolidate whitespace recognition

Hans-Peter Nilsson hp@bitrange.com
Fri Jan 31 06:02:26 GMT 2025


On Mon, 27 Jan 2025, Jan Beulich wrote:
> --- a/gas/read.c
> +++ b/gas/read.c
> @@ -112,9 +112,13 @@ die horribly;
>  
>  /* Used by is_... macros. our ctype[].  */
>  char lex_type[256] = {
> -  0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,	/* @ABCDEFGHIJKLMNO */
> +#ifndef CR_EOL
> +  0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 8, 0, 0,	/* @ABCDEFGHIJKLMNO */
> +#else
> +  0, 0, 0, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 0, 0, 0,	/* @ABCDEFGHIJKLMNO */
> +#endif
>    0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,	/* PQRSTUVWXYZ[\]^_ */
> -  0, 0, 0, LEX_HASH, LEX_DOLLAR, LEX_PCT, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, /* _!"#$%&'()*+,-./ */
> +  8, 0, 0, LEX_HASH, LEX_DOLLAR, LEX_PCT, 0, 0, 0, 0, 0, 0, 0, 0, 3, 0, /* _!"#$%&'()*+,-./ */
>    1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, LEX_QM,	/* 0123456789:;<=>? */
>    LEX_AT, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3,	/* @ABCDEFGHIJKLMNO */
>    3, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3, LEX_BR, 0, LEX_BR, 0, 3, /* PQRSTUVWXYZ[\]^_ */

Please use LEX_WHITE, not 8.  (Columns not lining up is not a 
valid excuse for naked literals, if that's the claimed reason.)

brgds, H-P


More information about the Binutils mailing list