[PATCH v2 00/65] gas: whitespace handling

Alan Modra amodra@gmail.com
Tue Jan 28 09:59:38 GMT 2025


On Mon, Jan 27, 2025 at 04:23:42PM +0100, Jan Beulich wrote:
> As per observations in target specific code there appears to be disagreement
> across the assembler whether to check for specific characters (blank and tab
> normally) or whether to use ISSPACE().
> 
> As agreed upon during the Cauldron in Prague, switch to a single base
> construct for all code to use: is_whitespace().
> 
> It clearly is an alternative option to have is_whitespace() expand to
> ISSPACE() or ISBLANK() (ISSPACE() also yields "true" for characters we don't
> really consider whitespace), then (obviously) leaving out the last patch. See
> also the CR_EOL uses in read.c and app.c. I think it is advisable though that
> is_whitespace() and is_end_of_{line,stmt}() be non-overlapping; question then
> is what (further) characters to tag as LEX_WHITE (see remarks in patch 01).
> 
> Along with recently (as of the v1 submission) committed work for x86 this
> appears to be sufficient to actually use -f (or #NO_APP at start of file)
> for gcc-generated code. I didn't properly check other architectures yet, but
> I seem to recall that at least Arm32 and PPC would apparently require
> compiler side adjustments, too.

I like it, thanks!

-- 
Alan Modra


More information about the Binutils mailing list