[PATCH] aarch64: Fix sve2p1 gating and add missing instructions

Srinath Parvathaneni Srinath.Parvathaneni@arm.com
Fri Jan 17 11:37:18 GMT 2025


Hi,

I have couple of comments on the patch.

>> diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h
>>index 755373557fc6e03da9d828ad4cbf4ca15541adff..dfe3f05820ab156bb7d5fc5c86dd6cbaba91065c 100644
>>--- a/include/opcode/aarch64.h
>>+++ b/include/opcode/aarch64.h
>>@@ -268,6 +268,8 @@ enum aarch64_feature_bit {
>>   AARCH64_FEATURE_SVE_B16B16,
>>   /* SME non-widening BFloat16 instructions.  */
>>   AARCH64_FEATURE_SME_B16B16,
>>+  /* Armv9.5-A processors.  */
>>+  AARCH64_FEATURE_V9_5A,

Seems like these changes are not relevant to this patch, maybe you can send
these separately with some explanation.

>>diff --git a/gas/testsuite/gas/aarch64/sve2-sme2-2.d b/gas/testsuite/gas/aarch64/sve2-sme2-2.d
>>index 9e60d1fd9b04cdc8ffce1838a3ec569e4f6add8e..6e9df901975d514707ecaa802f9890a0c7cdd478 100644
>>--- a/gas/testsuite/gas/aarch64/sve2-sme2-2.d
>>+++ b/gas/testsuite/gas/aarch64/sve2-sme2-2.d
>>@@ -1,4 +1,5 @@
>> #as: -march=armv8-a+sme2
>>+#as: -march=armv8-a+sve2p1
>> #objdump: -dr

I tried testing above testcase with following command using "+sme2p1+nosme2p1" and the assembler
does not throw any errors, seems like +sve2 is not removed from the command line on passing
+nosme2p1, which was added by +sme2p1.

$ aarch64-none-elf-as -march=armv8-a+sme2p1+nosme2p1 sve2-sme2-2.s

Regards,
Sri.


More information about the Binutils mailing list