[PATCH v2] x86: Ignore rounding for vcvt[,u]si2sd under r32 and vcvt[,u]dq2pd instead of reporting bad
Jiang, Haochen
haochen.jiang@intel.com
Thu Jan 16 08:24:29 GMT 2025
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Thursday, January 16, 2025 4:21 PM
>
> On 16.01.2025 03:44, Haochen Jiang wrote:
> > As said in previous thread, HW would accept those rounding encodings
> > so it would be safe to do that in toolchain.
> >
> > Changes and patch descrption are embedded following.
> >
> > Ok for trunk?
>
> I'm sorry, but no. I don't see justification for the assembler side change.
> For SAE-only insns we don't permit rounding control other than through the -
> mrcig= command line option. As a consequence I don't think we should permit
> rounding control via insn operand modifiers here either. Whether we want to
> make -mrcig= work for these insns I'm uncertain about; if so, that still
> shouldn't be by permitting {sae} operand modifiers on the insn operands, imo.
>
> Therefore, with the assembler change (and resulting testsuite adjustments)
> dropped, this is okay. If you want to pursue the assembler change, then please
> re-submit as an incremental change.
>
I will drop the assembler change. It does need some more time to discuss which
direction to go in assembler.
Thx,
Haochen
More information about the Binutils
mailing list