[PING]: [PATCH v2] ld: fix alignment issue for ARM thumb long branch stub using PureCode section
Nick Clifton
nickc@redhat.com
Tue Jan 7 09:29:32 GMT 2025
Hi Torbjorn,
> Gentle ping :)
Gentle pong. :-)
>> - Simplified new test case to fix issue reported by Linaro CI.
>>
>> Ok for trunk?
Approved with one small change:
>> +++ b/bfd/elf32-arm.c
>> @@ -2630,6 +2630,7 @@ static const insn_sequence elf32_arm_stub_long_branch_thumb2_only_pure[] =
>> THUMB32_MOVW (0xf2400c00), /* mov.w ip, R_ARM_MOVW_ABS_NC */
>> THUMB32_MOVT (0xf2c00c00), /* movt ip, R_ARM_MOVT_ABS << 16 */
>> THUMB16_INSN (0x4760), /* bx ip */
>> + THUMB16_INSN (0xbf00), /* nop */
>> };
Please could you add a comment here explaining why the NOP is present
and hopefully preventing future optimizers from deleting it.
Cheers
Nick
More information about the Binutils
mailing list