[PATCH v1] x86: Support Zhaoxin RNG2 instruction

[Jan Beulich]

On 30.12.2024 10:20, Mayshao-oc wrote:
>      This patch adds support for Zhaoxin RNG2 instruction.
>      Test ok, ok for trunk?

The change to output_insn() needs at least indenting correctly. The two
||-s don't really belong to the same level of the expression. Even better
would imo be to use (!is_cpu (&i.tm, CpuPadLock) &&
!is_cpu (&i.tm, CpuRNG2)) instead of the 2nd nested ||.

Speaking of RNG2 - we can only hope that no other vendor will come up with
a similarly abbreviated random number generator feature. The name is
pretty generic, after all. H.J. - what do you think?

Is there a connection between PadLock and RNG2? Does RNG2 perhaps even
imply PadLock as a prereq feature (wanting a dependency recorded in
i386-gen.c)? If so, naming it "PadLockRNG2" may be an option to avoid a
potential future clash.

Jan