[PATCH] ld/testsuite: add -z separate-code to sframe x86_64 tests

[Indu Bhagat]

On 2/24/25 6:59 AM, Clément Chigot wrote:
> Those tests were generated by a linker having "-z separate-code" on by
> default. However, being controlled by a configure option, it can be off
> by default. Forcing the option as part of the tests ensures clean
> results in both cases.

Looks OK to me.

> ---
>   ld/testsuite/ld-x86-64/sframe-ibt-plt-1.d | 2 +-
>   ld/testsuite/ld-x86-64/sframe-plt-1.d     | 2 +-
>   ld/testsuite/ld-x86-64/sframe-pltgot-1.d  | 2 +-
>   ld/testsuite/ld-x86-64/sframe-pltgot-2.d  | 2 +-
>   ld/testsuite/ld-x86-64/sframe-simple-1.d  | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/ld/testsuite/ld-x86-64/sframe-ibt-plt-1.d b/ld/testsuite/ld-x86-64/sframe-ibt-plt-1.d
> index 26be4dfc6a0..f8682421245 100644
> --- a/ld/testsuite/ld-x86-64/sframe-ibt-plt-1.d
> +++ b/ld/testsuite/ld-x86-64/sframe-ibt-plt-1.d
> @@ -1,7 +1,7 @@
>   #as: --gsframe
>   #source: ibt-plt-3.s
>   #objdump: --sframe=.sframe
> -#ld: -shared -z ibtplt --no-rosegment
> +#ld: -shared -z ibtplt --no-rosegment -z separate-code
>   #name: SFrame for IBT PLT .plt.sec
>   
>   .*: +file format .*
> diff --git a/ld/testsuite/ld-x86-64/sframe-plt-1.d b/ld/testsuite/ld-x86-64/sframe-plt-1.d
> index 52bca18d4c0..2918ccba1eb 100644
> --- a/ld/testsuite/ld-x86-64/sframe-plt-1.d
> +++ b/ld/testsuite/ld-x86-64/sframe-plt-1.d
> @@ -2,7 +2,7 @@
>   #source: sframe-foo.s
>   #source: sframe-bar.s
>   #objdump: --sframe=.sframe
> -#ld: -shared --no-rosegment
> +#ld: -shared --no-rosegment -z separate-code
>   #name: SFrame for plt0 and pltN
>   
>   .*: +file format .*
> diff --git a/ld/testsuite/ld-x86-64/sframe-pltgot-1.d b/ld/testsuite/ld-x86-64/sframe-pltgot-1.d
> index 23ff5d52fec..6c47770c2b5 100644
> --- a/ld/testsuite/ld-x86-64/sframe-pltgot-1.d
> +++ b/ld/testsuite/ld-x86-64/sframe-pltgot-1.d
> @@ -1,7 +1,7 @@
>   #as: --gsframe
>   #source: sframe-pltgot-1.s
>   #objdump: --sframe=.sframe
> -#ld: -shared -z ibtplt --no-rosegment
> +#ld: -shared -z ibtplt --no-rosegment -z separate-code
>   #name: SFrame for IBT .plt.got
>   
>   .*: +file format .*
> diff --git a/ld/testsuite/ld-x86-64/sframe-pltgot-2.d b/ld/testsuite/ld-x86-64/sframe-pltgot-2.d
> index 7a99d12faa8..141be292230 100644
> --- a/ld/testsuite/ld-x86-64/sframe-pltgot-2.d
> +++ b/ld/testsuite/ld-x86-64/sframe-pltgot-2.d
> @@ -1,7 +1,7 @@
>   #as: --gsframe
>   #source: sframe-pltgot-1.s
>   #objdump: --sframe=.sframe
> -#ld: -shared --no-rosegment
> +#ld: -shared --no-rosegment -z separate-code
>   #name: SFrame for .plt.got
>   
>   .*: +file format .*
> diff --git a/ld/testsuite/ld-x86-64/sframe-simple-1.d b/ld/testsuite/ld-x86-64/sframe-simple-1.d
> index 7d88419226f..3effdbf0529 100644
> --- a/ld/testsuite/ld-x86-64/sframe-simple-1.d
> +++ b/ld/testsuite/ld-x86-64/sframe-simple-1.d
> @@ -2,7 +2,7 @@
>   #source: sframe-foo.s
>   #source: sframe-bar.s
>   #objdump: --sframe=.sframe
> -#ld: -shared --no-rosegment
> +#ld: -shared --no-rosegment -z separate-code
>   #name: SFrame simple link
>   
>   .*: +file format .*