riscv disassembler leak

[Nelson Chu]

Thanks a lot :-)

Nelson

On Sun, Feb 16, 2025 at 6:42 AM Alan Modra <amodra@gmail.com> wrote:

> Commit 3f61a38b5e81 moved the disassembler subset_list from a static
> variable to disassembler private_data.  It is now malloc'd in
> riscv_init_disasm_info so should be freed when disassemble_free_target
> runs.
>
>         * riscv-dis.c (disassemble_free_riscv): Free subset_list.
>
> diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c
> index d67b2c2aaf0..84c6deef7b6 100644
> --- a/opcodes/riscv-dis.c
> +++ b/opcodes/riscv-dis.c
> @@ -1683,5 +1683,8 @@ void disassemble_free_riscv (struct disassemble_info
> *info ATTRIBUTE_UNUSED)
>  {
>    struct riscv_private_data *pd = info->private_data;
>    if (pd)
> -    riscv_release_subset_list (pd->riscv_rps_dis.subset_list);
> +    {
> +      riscv_release_subset_list (pd->riscv_rps_dis.subset_list);
> +      free (pd->riscv_rps_dis.subset_list);
> +    }
>  }
>
> --
> Alan Modra
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/binutils/attachments/20250218/9accc142/attachment.htm>