[PATCH] MIPS objdump: Add `eabi32` and `eabi64` ABI options

Maciej W. Rozycki macro@orcam.me.uk
Mon Feb 10 14:50:10 GMT 2025


Hi Anghelo,

 Thank you for your submission.  Overall it looks good to me, but can 
you please add a pair of test cases along the lines of:

gas/testsuite/gas/mips/fpr-names-32.d
gas/testsuite/gas/mips/gpr-names-32.d

for each of the EABI variants and wire them into?

gas/testsuite/gas/mips/mips.exp

?  It is so that we continue having coverage across the board for these 
register naming variants.

> From: angie <angheloalf95@gmail.com>

 Also please synchronise your authorship information and the SoB tag.

> Extend gpr and fpr register names with names suitable for both EABIs.
> 
> Heavily inspired by the EABI documenation written by Eric Christopher,
> which can be read at
> https://sourceware.org/legacy-ml/binutils/2003-06/msg00436.html

 Thank you for linking the reference into the change description.  As it 
only talks about argument registers when it comes to FPRs and does not 
mention which are static and which are temporary I have cross-checked it 
with GCC sources and things are looking good in your change.

> Signed-off-by: Anghelo Carvajal <angheloalf95@gmail.com>
> ---
>  opcodes/ChangeLog  |  6 ++++++
>  opcodes/mips-dis.c | 18 ++++++++++++++++++
>  2 files changed, 24 insertions(+)
> 
> diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
> index 609e621dada..bdbe59461ce 100644
> --- a/opcodes/ChangeLog
> +++ b/opcodes/ChangeLog
> @@ -1,3 +1,9 @@
> +2025-02-09  Anghelo Carvajal  <angheloalf95@gmail.com>
> +
> +        * mips-dis.c (mips_fpr_names_eabi32): New variable.
> +        (mips_fpr_names_eabi64): New variable.
> +        (mips_abi_choices): Added "eabi32" and "eabi64" options.

 We don't usually update ChangeLog files anymore, but you can include a 
record with your commit description if you like.  In that case please 
use the imperative mood though, i.e.:

	(mips_abi_choices): Add "eabi32" and "eabi64" options.

and please note that there has to be a single leading tab on each line 
rather than 8 spaces.

 As a matter of interest this is the first mention of the MIPS EABI I 
have seen in decades (which I gather means things have been working 
perfectly all the time on that side), so do you actually have a use for 
this stuff?

 Please send v2 with the updates requested and I'll be happy to accept 
your change.

  Maciej


More information about the Binutils mailing list