☠ Buildbot (Sourceware): binutils-gdb - failed compile (failure) (master)

[Alan Modra]

On Fri, Feb 07, 2025 at 12:29:18PM +0000, Luis Machado wrote:
> On 2/7/25 12:20, Luis Machado wrote:
> > On 2/7/25 08:19, Alan Modra wrote:
> >> On Thu, Feb 06, 2025 at 10:42:49PM +0000, builder@sourceware.org wrote:
> >>> A new failure has been detected on builder binutils-debian-amd64 while building binutils-gdb.
> >>
> >> --enable-targets=all results in
> >> eelf_x86_64_sol2.c:88:1: warning: ‘elf_x86_64_before_allocation’ defined but not used [-Wunused-function]
> >>    88 | elf_x86_64_before_allocation (void)
> >>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> Perhaps this?
> >>
> >> diff --git a/ld/emultempl/solaris2.em b/ld/emultempl/solaris2.em
> >> index a002b9f56c3..e176a14652e 100644
> >> --- a/ld/emultempl/solaris2.em
> >> +++ b/ld/emultempl/solaris2.em
> >> @@ -5,6 +5,13 @@ if [ -z "$MACHINE" ]; then
> >>  else
> >>    OUTPUT_ARCH=${ARCH}:${MACHINE}
> >>  fi
> >> +case x${OUTPUT_FORMAT} in
> >> +  x*x86-64*)
> >> +    next_before_allocation=elf_x86_64_before_allocation;;
> >> +  *)
> >> +    next_before_allocation=gld${EMULATION_NAME}_before_allocation;;
> >> +esac
> >> +
> >>  fragment <<EOF
> >>  /* This file is generated by a shell script.  DO NOT EDIT! */
> >>  
> >> @@ -135,7 +142,7 @@ elf_solaris2_before_allocation (void)
> >>        basever->vernum = 0;
> >>      }
> >>  
> >> -  gld${EMULATION_NAME}_before_allocation ();
> >> +  $next_before_allocation ();
> >>  }
> >>  
> >>  EOF
> >>
> > 
> > I'm also running into this from gdb's side.
> 
> And FYI, your patch fixes my build errors. Thanks!

I'm going to commit this patch instead.

diff --git a/ld/emultempl/solaris2.em b/ld/emultempl/solaris2.em
index a002b9f56c3..6198a82f24b 100644
--- a/ld/emultempl/solaris2.em
+++ b/ld/emultempl/solaris2.em
@@ -135,7 +135,7 @@ elf_solaris2_before_allocation (void)
       basever->vernum = 0;
     }
 
-  gld${EMULATION_NAME}_before_allocation ();
+  ${LDEMUL_BEFORE_ALLOCATION-gld${EMULATION_NAME}_before_allocation} ();
 }
 
 EOF

-- 
Alan Modra