[PATCH] x86: Support Zhaoxin PadLock XMODX instructions

Mayshao-oc Mayshao-oc@zhaoxin.com
Thu Feb 6 03:18:15 GMT 2025


> On 22.01.2025 03:50, Mayshao-oc wrote:
> >> On 17.01.2025 10:00, Mayshao-oc wrote:
> >>>      This patch adds support for Zhaoxin XMODX instructions.
> >>>      The CPUID EDX bit[28] indicates its enablement, and it includes 
> >>> REP XMODEXP and REP MONTMUL2. XMODX stands for modular 
> >>> exponentiation, it indicates the support of modular exponentiation 
> >>> feature, both REP XMODEXP and REP MONTMUL2 use it.
> >>>      Test ok, ok for trunk?
> >>
> >> Looks good to me, except there's a possible issue with the gas/NEWS entry:
> >> As you were likely aware up front, the 2.44 branch was created over 
> >> the weekend. Generally I wouldn't expect late feature additions to 
> >> still be eligible to go on the branch; Nick, do you concur? If so, 
> >> the existing entry may not be altered, and a new one (for 2.45) would 
> >> need creating instead. (Once this is settled, I'd be okay making the 
> >> adjustment [if necessary] while committing the change on your 
> >> behalf.)
> > Thanks for your comment. I appreciate you could commit the change on my behalf after the possible issue is settled.
> 
> Hmm, looking at it I fear the patch won't even apply anymore. Please re-submit a re-based version (also taking into account my comment from a minute ago regarding patch descriptions).
Thanks for your patience. I will not include unnecessary words in the patch descriptions any more. I resubmit a re-based version.
> 
> Jan
BR
MayShao
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-Support-x86-Zhaoxin-PadLock-XMODX-instructions_v2.patch
Type: application/octet-stream
Size: 7940 bytes
Desc: 0001-x86-Support-x86-Zhaoxin-PadLock-XMODX-instructions_v2.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20250206/8fcabfa2/attachment-0001.obj>


More information about the Binutils mailing list